From 0ea934c08f124a52fb4b69ef60b3e0a054afe041 Mon Sep 17 00:00:00 2001
From: rdiaz738 <diazroger738@gmail.com>
Date: Mon, 20 Apr 2026 17:24:16 -0700
Subject: [PATCH] Updated import and fixed race condition

---
 app/ytdl.py         |  6 +++--
 ui/src/app/app.html | 11 ++++++++
 ui/src/app/app.ts   | 62 ++++++++++++++++++++-------------------------
 3 files changed, 43 insertions(+), 36 deletions(-)

diff --git a/app/ytdl.py b/app/ytdl.py
index 2738447..d6df963 100644
--- a/app/ytdl.py
+++ b/app/ytdl.py
@@ -1140,9 +1140,11 @@ class DownloadQueue:
             if not self.queue.exists(id):
                 log.warning(f'requested cancel for non-existent download {id}')
                 continue
-            if self.queue.get(id).started():
-                self.queue.get(id).cancel()
+            dl = self.queue.get(id)
+            if dl.started():
+                dl.cancel()
             else:
+                dl.canceled = True
                 self.queue.delete(id)
                 await self.notifier.canceled(id)
         return {'status': 'ok'}
diff --git a/ui/src/app/app.html b/ui/src/app/app.html
index 9ec0472..2b294fd 100644
--- a/ui/src/app/app.html
+++ b/ui/src/app/app.html
@@ -608,6 +608,17 @@
             @if (batchImportStatus) {
               <small>{{ batchImportStatus }}</small>
             }
+            @if (importInProgress) {
+              <div class="progress mt-2" style="height: 20px;">
+                <div class="progress-bar" role="progressbar"
+                  [style.width.%]="batchImportTotal > 0 ? (batchImportCount / batchImportTotal) * 100 : 0"
+                  [attr.aria-valuenow]="batchImportCount"
+                  [attr.aria-valuemin]="0"
+                  [attr.aria-valuemax]="batchImportTotal">
+                  {{ batchImportCount }} / {{ batchImportTotal }}
+                </div>
+              </div>
+            }
           </div>
         </div>
         <div class="modal-footer">
diff --git a/ui/src/app/app.ts b/ui/src/app/app.ts
index d2a5110..9394680 100644
--- a/ui/src/app/app.ts
+++ b/ui/src/app/app.ts
@@ -104,6 +104,8 @@ export class App implements AfterViewInit, OnInit, OnDestroy {
   batchImportModalOpen = false;
   batchImportText = '';
   batchImportStatus = '';
+  batchImportCount = 0;
+  batchImportTotal = 0;
   importInProgress = false;
   cancelImportFlag = false;
   ytDlpOptionsUpdateTime: string | null = null;
@@ -1200,41 +1202,33 @@ export class App implements AfterViewInit, OnInit, OnDestroy {
       return;
     }
     this.importInProgress = true;
-    this.cancelImportFlag = false;
-    this.batchImportStatus = `Starting to import ${urls.length} URLs...`;
-    let index = 0;
-    const delayBetween = 1000;
-    const processNext = () => {
-      if (this.cancelImportFlag) {
-        this.batchImportStatus = `Import cancelled after ${index} of ${urls.length} URLs.`;
-        this.importInProgress = false;
-        return;
-      }
-      if (index >= urls.length) {
-        this.batchImportStatus = `Finished importing ${urls.length} URLs.`;
-        this.importInProgress = false;
-        return;
-      }
-      const url = urls[index];
-      this.batchImportStatus = `Importing URL ${index + 1} of ${urls.length}: ${url}`;
-      // Pass current selection options to backend
-      this.downloads.add(this.buildAddPayload({ url }))
-        .subscribe({
-          next: (status: Status) => {
-            if (status.status === 'error') {
-              alert(`Error adding URL ${url}: ${status.msg}`);
+    this.batchImportCount = 0;
+    this.batchImportTotal = urls.length;
+    this.batchImportStatus = `Sending ${urls.length} URLs to server...`;
+
+    const promises = urls.map(url =>
+      new Promise<void>((resolve) => {
+        this.downloads.add(this.buildAddPayload({ url })).subscribe({
+            next: (status: Status) => {
+              if (status.status === 'error') {
+                console.error(`Error adding URL ${url}: ${status.msg}`);
+              }
+              this.batchImportCount++;
+              resolve();
+            },
+            error: (err) => {
+              console.error(`Error importing URL ${url}:`, err);
+              this.batchImportCount++;
+              resolve();
             }
-            index++;
-            setTimeout(processNext, delayBetween);
-          },
-          error: (err) => {
-            console.error(`Error importing URL ${url}:`, err);
-            index++;
-            setTimeout(processNext, delayBetween);
-          }
-        });
-    };
-    processNext();
+          });
+      })
+    );
+
+    Promise.all(promises).then(() => {
+      this.batchImportStatus = `All ${urls.length} URLs sent to server.`;
+      this.importInProgress = false;
+    });
   }
 
   // Cancel the batch import process