Release 2.4.0 (#870)

* chore: bump version to v2.4.0-preview * Bump actions/cache from 4 to 5 (#865) Bumps [actions/cache](https://github.com/actions/cache) from 4 to 5. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/v4...v5) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Increase maximum DB connection pool size (#876) Increase DB connection timeout * Disable length limit for DB field PLUGIN_CONFIG.value (#875) * Bump actions/cache from 4 to 5 (#871) Bumps [actions/cache](https://github.com/actions/cache) from 4 to 5. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/v4...v5) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/download-artifact from 7 to 8 (#882) Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 7 to 8. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](https://github.com/actions/download-artifact/compare/v7...v8) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/upload-artifact from 6 to 7 (#881) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 6 to 7. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](https://github.com/actions/upload-artifact/compare/v6...v7) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/cache from 4 to 5 (#878) Bumps [actions/cache](https://github.com/actions/cache) from 4 to 5. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/v4...v5) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Dont perform scans if no metadata plugins are enabled (#877) * Dont perform scans if no metadata plugins are enabled * Fix tests * Add PluginServiceTest.kt * Fix Sonar finding * Fix malformed external links (#886) * Fix external links being treated as internal * chore: bump version to v856-malformed-external-links-preview * Update JVM in Dockerfile to Java 25 * Revert incorrect version update * Allow loading .jar plugins in development mode (#885) * Allow loading .jar plugins in development mode * Remove unnecessary mock * Fix unit test * Add unit tests * Fix/879 add info and reset to config options (#887) * Fix gog.sh script * Add "description" property to ConfigProperties.kt Add InfoPopup.tsx and ResetToDefaultButton.tsx in UI * Bump actions/download-artifact from 7 to 8 (#891) Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 7 to 8. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](https://github.com/actions/download-artifact/compare/v7...v8) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/cache from 4 to 5 (#890) Bumps [actions/cache](https://github.com/actions/cache) from 4 to 5. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/v4...v5) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/upload-artifact from 6 to 7 (#889) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 6 to 7. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](https://github.com/actions/upload-artifact/compare/v6...v7) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Improve memory usage and performance (#888) mprove memory usage and performance by: * Using AOT cache * Using tuned JAVA_OPTIONS * Session timeout * Jetty threadpool * DB batch size * DB pool size * Library scanning * Make scan-concurrency configurable * Log retention * Off-load image processing to disk instead of RAM * Fix bug in PluginState * Update dependency version for ksp * Fix race condition preventing plugins from starting * Show remaining time (estimation) for library scans * Add unit test for plugin loading bugfix * Add unit tests for ImageService calculateBlurHash * Make username claim configurable (#895) Add fallbacks to resolve username * Fix sonar issues (#894) * Add custom "/sonar" command to GH copilot * Add Sonar plugin integration * Fix issues reported by Sonar * Ignore Sonar warning about AES/ECB * Add unit tests for GameyfinPluginManager * Add unit tests for GameService * Add more unit tests for GameService * Improve library card layout (#896) * Fix title not being centered * Add buttons to scan all libraries * Disable AVX for AOT cache training * Improve AOT cache training * Fix tests * Change output type of Docker Build CI action * Increase MAX_WAIT of aot-training to 5min * Optimize Docker CI pipeline * Add Sonar badges to README.md * Add custom metrics (downloads & scans) * Optimize DB connection & add cache for images * Adjusted logging on startup * * Show message on start page when no libraries/games are available * Disable "Scan" buttons when no metadata plugin is enabled * Fix thread pinning causing deadlocks * Pre-populate image cache at startup * Show "Loading" spinner while loading * Optimize static file serving (images) * Switch back to Tomcat (from Jetty) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-06-13 16:40:01 +00:00 · 2026-03-13 15:34:06 +01:00
parent ecd369cd30
commit 3a932d953f
123 changed files with 6169 additions and 2003 deletions
@@ -0,0 +1,70 @@
+name: 'Docker Build Platform'
+description: 'Builds and pushes a single-platform Docker image by digest.'
+runs:
+  using: 'composite'
+  steps:
+    - name: Prepare platform pair
+      id: prepare
+      shell: bash
+      run: |
+        platform="${{ inputs.platform }}"
+        echo "platform_pair=${platform//\//-}" >> $GITHUB_OUTPUT
+
+    - name: Set up Docker Buildx
+      uses: docker/setup-buildx-action@v3
+
+    - name: Log in to GHCR
+      uses: docker/login-action@v3
+      with:
+        registry: ghcr.io
+        username: ${{ inputs.ghcr_username }}
+        password: ${{ inputs.ghcr_token }}
+
+    - name: Build and push by digest
+      id: build
+      uses: docker/build-push-action@v6
+      env:
+        BUILDKIT_PROGRESS: plain
+      with:
+        context: ${{ inputs.context }}
+        file: ${{ inputs.file }}
+        platforms: ${{ inputs.platform }}
+        outputs: type=image,"name=${{ inputs.image_name }}",push-by-digest=true,name-canonical=true,push=true
+        cache-from: type=gha,scope=build-${{ steps.prepare.outputs.platform_pair }}
+        cache-to: type=gha,mode=max,scope=build-${{ steps.prepare.outputs.platform_pair }}
+
+    - name: Export digest
+      shell: bash
+      run: |
+        mkdir -p "${{ runner.temp }}/digests"
+        digest="${{ steps.build.outputs.digest }}"
+        touch "${{ runner.temp }}/digests/${digest#sha256:}"
+
+    - name: Upload digest
+      uses: actions/upload-artifact@v7
+      with:
+        name: digests-${{ steps.prepare.outputs.platform_pair }}
+        path: ${{ runner.temp }}/digests/*
+        if-no-files-found: error
+        retention-days: 1
+
+inputs:
+  ghcr_username:
+    required: true
+    description: 'GHCR username'
+  ghcr_token:
+    required: true
+    description: 'GHCR token'
+  context:
+    required: true
+    description: 'Build context'
+  file:
+    required: true
+    description: 'Dockerfile path'
+  platform:
+    required: true
+    description: 'Target platform (e.g. linux/amd64)'
+  image_name:
+    required: true
+    description: 'Image name without tag (e.g. ghcr.io/gameyfin/gameyfin)'
+
@@ -1,8 +1,15 @@
-name: 'Docker Build and Push'
-description: 'Builds and pushes Docker images to GHCR with flexible tagging.'
+name: 'Docker Create Manifest'
+description: 'Creates and pushes a multi-arch manifest from per-platform digests.'
 runs:
  using: 'composite'
  steps:
+    - name: Download digests
+      uses: actions/download-artifact@v8
+      with:
+        path: ${{ runner.temp }}/digests
+        pattern: digests-*
+        merge-multiple: true
+
    - name: Set up Docker Buildx
      uses: docker/setup-buildx-action@v3

@@ -24,16 +31,19 @@ runs:
        COMBINED_TAGS="$DEFAULT_TAGS,$UBUNTU_TAGS"
        echo "combined_tags=$COMBINED_TAGS" >> $GITHUB_OUTPUT

-    - name: Build and push Docker image (Ubuntu)
-      uses: docker/build-push-action@v5
-      with:
-        context: ${{ inputs.context }}
-        file: docker/Dockerfile.ubuntu
-        platforms: ${{ inputs.platforms }}
-        push: true
-        tags: ${{ steps.combined_tags.outputs.combined_tags }}
-        cache-from: type=gha
-        cache-to: type=gha
+    - name: Create manifest list and push
+      shell: bash
+      working-directory: ${{ runner.temp }}/digests
+      run: |
+        TAG_ARGS=$(echo "${{ steps.combined_tags.outputs.combined_tags }}" | tr ',' '\n' | xargs -I {} echo "-t {}" | tr '\n' ' ')
+        docker buildx imagetools create $TAG_ARGS \
+          $(printf '${{ inputs.image_name }}@sha256:%s ' *)
+
+    - name: Inspect image
+      shell: bash
+      run: |
+        TAG=$(echo "${{ inputs.tags }}" | cut -d',' -f1)
+        docker buildx imagetools inspect "$TAG"

 inputs:
  ghcr_username:
@@ -42,16 +52,10 @@ inputs:
  ghcr_token:
    required: true
    description: 'GHCR token'
-  context:
-    required: true
-    description: 'Build context'
-  dockerfile:
-    required: true
-    description: 'Dockerfile path'
-  platforms:
-    required: true
-    description: 'Platforms to build for'
  tags:
    required: true
    description: 'Comma-separated list of image tags'
+  image_name:
+    required: true
+    description: 'Image name without tag (e.g. ghcr.io/gameyfin/gameyfin)'

@@ -0,0 +1,7 @@
+---
+description: Analyze and fix Sonar issues reported in this file
+---
+
+Sonar reported some issues in this file, please fix them.
+Use the "list warnings/errors" command to get the list of issues, and then fix them one by one.
+
@@ -34,16 +34,24 @@ jobs:
          report_paths: '**/build/test-results/test/TEST-*.xml'

      - name: Upload build outputs
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
        with:
          name: build-outputs
          path: |
            app/build/libs/**
            plugins/**/build/libs/**/*.jar

-  docker:
+  docker-build:
    needs: build
-    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - platform: linux/amd64
+            runner: ubuntu-24.04
+          - platform: linux/arm64
+            runner: ubuntu-24.04-arm
+    runs-on: ${{ matrix.runner }}
    permissions:
      packages: write
    steps:
@@ -51,11 +59,30 @@ jobs:
        uses: actions/checkout@v6

      - name: Download build outputs
-        uses: actions/download-artifact@v7
+        uses: actions/download-artifact@v8
        with:
          name: build-outputs
          path: .

+      - name: Build platform image
+        uses: ./.github/actions/docker-build-platform
+        with:
+          ghcr_username: ${{ github.actor }}
+          ghcr_token: ${{ secrets.GITHUB_TOKEN }}
+          context: .
+          file: docker/Dockerfile.ubuntu
+          platform: ${{ matrix.platform }}
+          image_name: ghcr.io/gameyfin/gameyfin
+
+  docker-merge:
+    needs: [build, docker-build]
+    runs-on: ubuntu-latest
+    permissions:
+      packages: write
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v6
+
      - name: Extract tag from branch name
        id: extract_tag
        run: |
@@ -63,12 +90,10 @@ jobs:
          TAG="${BRANCH_NAME#fix/}"
          echo "tag=$TAG" >> $GITHUB_OUTPUT

-      - name: Build and push Docker image
-        uses: ./.github/actions/docker-build-push
+      - name: Create and push manifest
+        uses: ./.github/actions/docker-create-manifest
        with:
          ghcr_username: ${{ github.actor }}
          ghcr_token: ${{ secrets.GITHUB_TOKEN }}
-          context: .
-          dockerfile: docker/Dockerfile
-          platforms: linux/arm64/v8,linux/amd64
          tags: ghcr.io/gameyfin/gameyfin:${{ steps.extract_tag.outputs.tag }}
+          image_name: ghcr.io/gameyfin/gameyfin
@@ -64,16 +64,24 @@ jobs:
          report_paths: '**/build/test-results/test/TEST-*.xml'

      - name: Upload build outputs
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
        with:
          name: build-outputs
          path: |
            app/build/libs/**
            plugins/**/build/libs/**/*.jar

-  docker:
+  docker-build:
    needs: build
-    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - platform: linux/amd64
+            runner: ubuntu-24.04
+          - platform: linux/arm64
+            runner: ubuntu-24.04-arm
+    runs-on: ${{ matrix.runner }}
    permissions:
      packages: write
    steps:
@@ -83,17 +91,36 @@ jobs:
          fetch-depth: 0

      - name: Download build outputs
-        uses: actions/download-artifact@v7
+        uses: actions/download-artifact@v8
        with:
          name: build-outputs
          path: .

-      - name: Build and push Docker image
-        uses: ./.github/actions/docker-build-push
+      - name: Build platform image
+        uses: ./.github/actions/docker-build-platform
        with:
          ghcr_username: ${{ github.actor }}
          ghcr_token: ${{ secrets.GITHUB_TOKEN }}
          context: .
-          dockerfile: docker/Dockerfile
-          platforms: linux/arm64/v8,linux/amd64
+          file: docker/Dockerfile.ubuntu
+          platform: ${{ matrix.platform }}
+          image_name: ghcr.io/gameyfin/gameyfin
+
+  docker-merge:
+    needs: [build, docker-build]
+    runs-on: ubuntu-latest
+    permissions:
+      packages: write
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v6
+        with:
+          fetch-depth: 0
+
+      - name: Create and push manifest
+        uses: ./.github/actions/docker-create-manifest
+        with:
+          ghcr_username: ${{ github.actor }}
+          ghcr_token: ${{ secrets.GITHUB_TOKEN }}
          tags: ghcr.io/gameyfin/gameyfin:${{ needs.build.outputs.version }}
+          image_name: ghcr.io/gameyfin/gameyfin
@@ -50,7 +50,7 @@ jobs:
          jq ".version = \"$RELEASE_VERSION\"" app/package.json > app/package.json.tmp && mv app/package.json.tmp app/package.json

      - name: Upload modified files
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
        with:
          name: modified-files
          path: |
@@ -71,7 +71,7 @@ jobs:
          fetch-depth: 0

      - name: Download modified files
-        uses: actions/download-artifact@v7
+        uses: actions/download-artifact@v8
        with:
          name: modified-files

@@ -95,16 +95,24 @@ jobs:
          report_paths: '**/build/test-results/test/TEST-*.xml'

      - name: Upload build outputs
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
        with:
          name: build-outputs
          path: |
            app/build/libs/**
            plugins/**/build/libs/**/*.jar

-  docker:
-    needs: [ setup, build ]
-    runs-on: ubuntu-latest
+  docker-build:
+    needs: [setup, build]
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - platform: linux/amd64
+            runner: ubuntu-24.04
+          - platform: linux/arm64
+            runner: ubuntu-24.04-arm
+    runs-on: ${{ matrix.runner }}
    permissions:
      packages: write
    steps:
@@ -114,16 +122,37 @@ jobs:
          fetch-depth: 0

      - name: Download modified files
-        uses: actions/download-artifact@v7
+        uses: actions/download-artifact@v8
        with:
          name: modified-files

      - name: Download build outputs
-        uses: actions/download-artifact@v7
+        uses: actions/download-artifact@v8
        with:
          name: build-outputs
          path: .

+      - name: Build platform image
+        uses: ./.github/actions/docker-build-platform
+        with:
+          ghcr_username: ${{ github.actor }}
+          ghcr_token: ${{ secrets.GITHUB_TOKEN }}
+          context: .
+          file: docker/Dockerfile.ubuntu
+          platform: ${{ matrix.platform }}
+          image_name: ghcr.io/gameyfin/gameyfin
+
+  docker-merge:
+    needs: [setup, docker-build]
+    runs-on: ubuntu-latest
+    permissions:
+      packages: write
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v6
+        with:
+          fetch-depth: 0
+
      - name: Generate container image tags
        id: docker_tags
        run: |
@@ -138,15 +167,13 @@ jobs:
          TAGS="$GHCR_TAGS"
          echo "tags=$TAGS" >> $GITHUB_OUTPUT

-      - name: Build and push Docker image
-        uses: ./.github/actions/docker-build-push
+      - name: Create and push manifest
+        uses: ./.github/actions/docker-create-manifest
        with:
          ghcr_username: ${{ github.actor }}
          ghcr_token: ${{ secrets.GITHUB_TOKEN }}
-          context: .
-          dockerfile: docker/Dockerfile
-          platforms: linux/arm64/v8,linux/amd64
          tags: ${{ steps.docker_tags.outputs.tags }}
+          image_name: ghcr.io/gameyfin/gameyfin

  plugin_api:
    needs: setup
@@ -158,7 +185,7 @@ jobs:
          fetch-depth: 0

      - name: Download modified files
-        uses: actions/download-artifact@v7
+        uses: actions/download-artifact@v8
        with:
          name: modified-files

@@ -180,7 +207,7 @@ jobs:
          ORG_GRADLE_PROJECT_mavenCentralPassword: ${{ secrets.MAVENCENTRAL_PASSWORD }}

  finalize:
-    needs: [ docker, plugin_api ]
+    needs: [ docker-merge, plugin_api ]
    runs-on: ubuntu-latest
    steps:
      - name: Checkout code
@@ -189,7 +216,7 @@ jobs:
          fetch-depth: 0

      - name: Download modified files
-        uses: actions/download-artifact@v7
+        uses: actions/download-artifact@v8
        with:
          name: modified-files

@@ -28,7 +28,7 @@ jobs:
        uses: gradle/actions/setup-gradle@v5

      - name: Cache SonarCloud packages
-        uses: actions/cache@v4
+        uses: actions/cache@v5
        with:
          path: ~/.sonar/cache
          key: ${{ runner.os }}-sonar