Fix bug in error handler response handling

Change background of Sonner
This commit is contained in:
grimsi
2024-06-08 16:05:25 +02:00
parent 96c89662ec
commit 273e9b0a07
4 changed files with 25 additions and 17 deletions
+18 -7
View File
@@ -2,19 +2,30 @@ import {Middleware, MiddlewareContext, MiddlewareNext} from '@hilla/frontend';
import {toast} from "sonner";
import {getReasonPhrase} from "http-status-codes";
export const ErrorHandlingMiddleware: Middleware = async function(
export const ErrorHandlingMiddleware: Middleware = async function (
context: MiddlewareContext,
next: MiddlewareNext
) {
const {endpoint, method} = context;
let response: Response = await next(context);
if(!response.ok) {
//Ignore calls to UserEndpoint.getUserInfo since they are managed by Hilla and called on initial load
if(endpoint == "UserEndpoint" && method == "getUserInfo") return response;
let originalResponse = (await next(context));
toast.error(`${getReasonPhrase(response.status)}`, {description: `${endpoint}.${method}`})
if (!originalResponse.ok) {
// .clone() is necessary because response.json() is one-time only and Hilla accesses it in its internal error handler
// @see https://developer.mozilla.org/en-US/docs/Web/API/Response/clone
let response: Response = originalResponse.clone();
//Ignore calls to UserEndpoint.getUserInfo since they are managed by Hilla and called on initial load
if (endpoint == "UserEndpoint" && method == "getUserInfo") return originalResponse;
let json: any = await response.json();
if (json.type == "dev.hilla.exception.EndpointException") {
toast.error(`${getReasonPhrase(response.status)}`, {description: `${json.message}`});
} else {
toast.error(`${getReasonPhrase(response.status)}`, {description: `${endpoint}.${method}`})
}
}
return response;
return originalResponse;
}