Refactor directory size calculation

This commit is contained in:
grimsi
2022-08-10 21:58:47 +02:00
parent 38bbdc7c57
commit 02656cf6f9
@@ -8,9 +8,12 @@ import de.grimsi.gameyfin.service.LibraryService;
import de.grimsi.gameyfin.util.ProtobufUtil; import de.grimsi.gameyfin.util.ProtobufUtil;
import lombok.RequiredArgsConstructor; import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j; import lombok.extern.slf4j.Slf4j;
import org.apache.commons.io.FileUtils;
import org.springframework.stereotype.Component; import org.springframework.stereotype.Component;
import org.springframework.util.StopWatch;
import org.springframework.util.StringUtils; import org.springframework.util.StringUtils;
import java.io.File;
import java.io.IOException; import java.io.IOException;
import java.nio.file.FileSystem; import java.nio.file.FileSystem;
import java.nio.file.FileSystems; import java.nio.file.FileSystems;
@@ -49,7 +52,7 @@ public class GameMapper {
.themes(ThemeMapper.toThemes(g.getThemesList())) .themes(ThemeMapper.toThemes(g.getThemesList()))
.playerPerspectives(PlayerPerspectiveMapper.toPlayerPerspectives(g.getPlayerPerspectivesList())) .playerPerspectives(PlayerPerspectiveMapper.toPlayerPerspectives(g.getPlayerPerspectivesList()))
.path(path.toString()) .path(path.toString())
.diskSize(calculateDiskSize(path)) .diskSize(calculateDiskSize(g, path))
.build(); .build();
} }
@@ -93,15 +96,18 @@ public class GameMapper {
return modes.stream().mapToInt(Igdb.MultiplayerMode::getOnlinecoopmax).max().orElse(0); return modes.stream().mapToInt(Igdb.MultiplayerMode::getOnlinecoopmax).max().orElse(0);
} }
private static long calculateDiskSize(Path path) { private static long calculateDiskSize(Igdb.Game g, Path path) {
try(Stream<Path> pathStream = Files.walk(path)) { StopWatch stopWatch = new StopWatch();
return pathStream log.info("Calculating disk size for game '{}'...", g.getName());
.filter(p -> p.toFile().isFile())
.mapToLong(p -> p.toFile().length()) stopWatch.start();
.sum();
} catch (IOException e) { // Some benchmarks I did have shown that trying to parallelize this process makes it slower instead of faster
log.error("Unable to calculate size for path '{}'.", path); long fileSize = FileUtils.sizeOfDirectory(path.toFile());
return -1;
} stopWatch.stop();
log.info("Calculated disk size for game {} in {} seconds", g.getName(), (int) stopWatch.getTotalTimeSeconds());
return fileSize;
} }
} }